Use the native URL.createObjectURL method in web/debugger.js
#11545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no particular reason for using the PDF.js helper function `createObjectURL`[1] in the debugger, instead of the native `URL.createObjectURL` directly, for a couple of reasons: - The relevant code-path only applies to fonts loaded with the Font Loading API, and this isn't supported in IE anyway. - The debugger can, since quite some time, not even be loaded in IE any more. - General support for IE is now limited, and there's no guaratee that everything actually works. --- [1] It provides a fallback for browsers with broken `Blob` support, which as usual means Internet Explorer :-P
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b709a4f6c8a0b33/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b709a4f6c8a0b33/output.txt Total script time: 1.74 mins Published |
timvandermeij
approved these changes
Jan 28, 2020
|
Always good to start using native methods; thanks! |
nmtigor
reviewed
Jun 6, 2022
| @@ -121,7 +119,9 @@ var FontInspector = (function FontInspectorClosure() { | |||
| url = /url\(['"]?([^\)"']+)/.exec(url); | |||
| download.href = url[1]; | |||
| } else if (fontObj.data) { | |||
| download.href = createObjectURL(fontObj.data, fontObj.mimeType); | |||
| download.href = URL.createObjectURL( | |||
| new Blob([fontObj.data], { type: fontObj.mimeType }) | |||
There was a problem hiding this comment.
Should this be
new Blob([fontObj.data], { type: fontObj.mimetype })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no particular reason for using the PDF.js helper function
createObjectURL[1] in the debugger, instead of the nativeURL.createObjectURLdirectly, for a couple of reasons:[1] It provides a fallback for browsers with broken
Blobsupport, which as usual means Internet Explorer :-P