Enable the ESLint prefer-const rule globally (PR 11450 follow-up)
#11534
Conversation
|
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/579cb2aea8d7f5e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ee61e7e25ecfc8a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ee61e7e25ecfc8a/output.txt Total script time: 1.17 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/579cb2aea8d7f5e/output.txt Total script time: 2.62 mins
|
Snuffleupagus
force-pushed
the
prefer-const
branch
from
007e676 to
0616693
Compare
Snuffleupagus
changed the title
prefer-const rule globally (PR 11450)prefer-const rule globally (PR 11450 follow-up)
Snuffleupagus
force-pushed
the
prefer-const
branch
from
0616693 to
cc7d755
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c52863a2048ddb9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a4b4a50ae45b427/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/c52863a2048ddb9/output.txt Total script time: 19.48 mins
Image differences available at: http://54.67.70.0:8877/c52863a2048ddb9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/a4b4a50ae45b427/output.txt Total script time: 26.01 mins
Image differences available at: http://54.215.176.217:8877/a4b4a50ae45b427/reftest-analyzer.html#web=eq.log |
Please find additional details about the ESLint rule at https://eslint.org/docs/rules/prefer-const With the recent introduction of Prettier this sort of mass enabling of ESLint rules becomes a lot easier, since the code will be automatically reformatted as necessary to account for e.g. changed line lengths. Note that this patch is generated automatically, by using the ESLint `--fix` argument, and will thus require some additional clean-up (which is done separately).
… rule globally This covers cases that the `--fix` command couldn't deal with, and in a few cases (notably `src/core/jbig2.js`) the code was changed to use block-scoped variables instead.
Snuffleupagus
force-pushed
the
prefer-const
branch
from
cc7d755 to
83bdb52
Compare
As always, thank you for reviewing these bigger patches! We may also want to look into enabling the |
No description provided.