Remove the "useOnlyCssZoom" (debugging) hash parameter #11533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hash is empty For people running e.g. Firefox with the `pdfBugEnabled` preference set, to allow quick access to debugging tools, this method will obviously run for every opened PDF file. However, in most cases the URL hash is empty and we can thus skip most of the parsing and simply return early instead.
The debugging hash parameters[1] are intended to facilitate access to various tools/settings in PRODUCTION builds, protected by the `pdfBugEnabled` preference. At this point, the remaining debugging hash parameters are mainly intended to allow access to the `PDFBug` tools and/or to quickly toggle certain larger features. The "useOnlyCssZoom" functionality doesn't really seem to fit in with the rest of these hash parameters, since: - This is, comparatively speaking, a minor viewer-specific feature. - The zooming implementation will (almost) always fallback to CSS-only zooming, for any document, once the canvases becomes large enough. Hence, the majority of the CSS zooming feature can still be tested *directly* in any build of the viewer. - After the initial implementation, years ago, the CSS-only zooming code in question hasn't changed much (or even at all), i.e. it doesn't seem like an active development target.[2] - If the "useOnlyCssZoom" functionality was added today, it's unlikely that a hash parameter would've been added. - Last, but not least, there's also a `useOnlyCssZoom` preference hence toggling this functionality shouldn't be too difficult (e.g. if someone needs to hack on it). All in all, I'm thus suggesting that we remove the "useOnlyCssZoom" hash parameter. --- [1] Originally these hash parameters could be used directly in any build, which was bad since it would allow any link to potentially disable functionality and/or reduce performance. [2] If it had seen active development over the years, I'd be *much* more inclined to keep the hash parameter.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/280cfe04135f6a0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/280cfe04135f6a0/output.txt Total script time: 1.73 mins Published |
timvandermeij
approved these changes
Jan 23, 2020
|
Good idea to clean up the hash parameters a bit. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debugging hash parameters[1] are intended to facilitate access to various tools/settings in PRODUCTION builds, protected by the
pdfBugEnabledpreference.At this point, the remaining debugging hash parameters are mainly intended to allow access to the
PDFBugtools and/or to quickly toggle certain larger features.The "useOnlyCssZoom" functionality doesn't really seem to fit in with the rest of these hash parameters, since:
useOnlyCssZoompreference hence toggling this functionality shouldn't be too difficult (e.g. if someone needs to hack on it).All in all, I'm thus suggesting that we remove the "useOnlyCssZoom" hash parameter.
[1] Originally these hash parameters could be used directly in any build, which was bad since it would allow any link to potentially disable functionality and/or reduce performance.
[2] If it had seen active development over the years, I'd be much more inclined to keep the hash parameter.