Update the GlobalWorkerOptions.workerSrc JSDoc comment
#11520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular JSDoc comment is fairly old and it also contains some now unrelated/confusing information. The only way to *guarantee* that the PDF.js library works as expected is to correctly set the global `workerSrc`[1], hence giving the impression that the option isn't strictly necessary is thus incorrect. --- [1] Since advertising the fallbackWorkerSrc functionality definitely seems like the *wrong* thing to do.
Snuffleupagus
force-pushed
the
workerSrc-docs
branch
from
af25e17 to
ee87e89
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6ae49925baf6e88/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6ae49925baf6e88/output.txt Total script time: 9.95 mins Published |
timvandermeij
approved these changes
Jan 19, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular JSDoc comment is fairly old and it also contains some now unrelated/confusing information.
The only way to guarantee that the PDF.js library works as expected is to correctly set the global
workerSrc[1], hence giving the impression that the option isn't strictly necessary is thus incorrect.[1] Since advertising the fallbackWorkerSrc functionality definitely seems like the wrong thing to do.