[Firefox] Ensure that telemetry will be correctly recorded even when the PDF header is missing (bug 1606566) #11463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fbe3fb2df9b84d6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/fbe3fb2df9b84d6/output.txt Total script time: 1.74 mins Published |
Rob--W
approved these changes
Jan 1, 2020
Snuffleupagus
force-pushed
the
bug-1606566
branch
from
30f49e0 to
bd56235
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/eb4993e1efda3c3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/eb4993e1efda3c3/output.txt Total script time: 1.72 mins Published |
…the PDF header is missing (bug 1606566) As suggested in the bug we'll now always fallback to "other", which should be fine considering that that value is listed in the histogram definition; see https://searchfox.org/mozilla-central/rev/331f0c3b25089c9a16be65f4dc8c601aeaac8cc4/toolkit/components/telemetry/Histograms.json#9097-9106 Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1606566
Snuffleupagus
force-pushed
the
bug-1606566
branch
from
bd56235 to
bee941b
Compare
Rob--W
approved these changes
Jan 1, 2020
|
Thanks for the quick patch for my bug report. Happy New Year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in the bug we'll now always fallback to "other", which should be fine considering that that value is listed in the histogram definition; see https://searchfox.org/mozilla-central/rev/331f0c3b25089c9a16be65f4dc8c601aeaac8cc4/toolkit/components/telemetry/Histograms.json#9097-9106
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1606566
/cc @Rob--W