Enable the ESLint prefer-const rule in the web/ directory
#11450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of doing this all at once, both to reduce code churn and to simply be done with it quickly :-) I'm afraid the previous merge required a rebase here, but hopefully it's not too difficult given that ESLint's |
Please find additional details about the ESLint rule at https://eslint.org/docs/rules/prefer-const Note that this patch is generated automatically, by using the ESLint `--fix` argument, and will thus require some additional clean-up (which is done separately).
… rule in the `web/` directory This covers the handful of cases that the `--fix` command couldn't deal with, and the changes aren't just fixing the linting errors but attempt to slightly improve the relevant code.
Snuffleupagus
force-pushed
the
eslint-web-prefer-const
branch
from
0cf4c18 to
d9a5d50
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a6024488a9c877c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a6024488a9c877c/output.txt Total script time: 1.69 mins Published |
timvandermeij
approved these changes
Dec 27, 2019
|
Nice work; glad that this conversion is done for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the ESLint
prefer-construle in theweb/directoryPlease find additional details about the ESLint rule at https://eslint.org/docs/rules/prefer-const
Note that this patch is generated automatically, by using the ESLint
--fixargument, and will thus require some additional clean-up (which is done separately).Fix remaining linting errors, from enabling the
prefer-constESLint rule in theweb/directoryThis covers the handful of cases that the
--fixcommand couldn't deal with, and the changes aren't just fixing the linting errors but attempt to slightly improve the relevant code.