Move the regular expression, used with auto printing in the viewer, to web/ui_utils.js and also use it in the API unit-tests
#11449
Conversation
Snuffleupagus
changed the title
web/ui_utils.js and also use it in the API unit-testsweb/ui_utils.js and also use it in the API unit-tests
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5dfacce13458161/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5dfacce13458161/output.txt Total script time: 1.71 mins Published |
Snuffleupagus
force-pushed
the
AutoPrintRegExp
branch
from
4991ff4 to
b348a21
Compare
|
Looks good if the newly added unit test is also adjusted. |
…o `web/ui_utils.js` and also use it in the API unit-tests Rather than having a copy of this regular expression in the `test/unit/api_spec.js` file, with a comment about keeping it up-to-date with the code in the viewer (note the incorrect file reference as well), we can just import it instead to simplify all of this.
Snuffleupagus
force-pushed
the
AutoPrintRegExp
branch
from
b348a21 to
d9d8560
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/802286d3635211d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/fa321d6d5879a12/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/802286d3635211d/output.txt Total script time: 2.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/fa321d6d5879a12/output.txt Total script time: 5.10 mins
|
|
Nice improvement! |
Rather than having a copy of this regular expression in the
test/unit/api_spec.jsfile, with a comment about keeping it up-to-date with the code in the viewer (note the incorrect file reference as well), we can just import it instead to simplify all of this.This is something I noticed while looking at PR #11445, I'll rebase this once that one has landed.