Ensure that PDFDocument.checkFirstPage waits for cleanup to complete (PR 10392 follow-up)
#11390
Conversation
…e (PR 10392 follow-up) Given how this method is currently used there shouldn't be any fonts loaded at the point in time where it's called, but it does seem like a bad idea to assume that that's always going to be the case. Since `PDFDocument.checkFirstPage` is already asynchronous, it's easy enough to simply await `Catalog.cleanup` here. (The patch also makes a tiny simplification in a loop in `Catalog.cleanup`.)
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/11301af79d25234/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b2cd81f067c123f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b2cd81f067c123f/output.txt Total script time: 18.80 mins
Image differences available at: http://54.67.70.0:8877/b2cd81f067c123f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/11301af79d25234/output.txt Total script time: 26.73 mins
|
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/424fe0081e9052e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f3fb32bedfac84f/output.txt |
Snuffleupagus
force-pushed
the
checkFirstPage-await-cleanup
branch
from
96ea33d to
a02122e
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/424fe0081e9052e/output.txt Total script time: 18.82 mins
Image differences available at: http://54.67.70.0:8877/424fe0081e9052e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/f3fb32bedfac84f/output.txt Total script time: 26.36 mins
Image differences available at: http://54.215.176.217:8877/f3fb32bedfac84f/reftest-analyzer.html#web=eq.log |
|
Looks good! |
Given how this method is currently used there shouldn't be any fonts loaded at the point in time where it's called, but it does seem like a bad idea to assume that that's always going to be the case. Since
PDFDocument.checkFirstPageis already asynchronous, it's easy enough to simply awaitCatalog.cleanuphere.(The patch also makes a tiny simplification in a loop in
Catalog.cleanup.)