Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: viewer.css refactored, duplications removed #11268

Merged
merged 1 commit into from
Oct 22, 2019
Merged

refactor: viewer.css refactored, duplications removed #11268

merged 1 commit into from
Oct 22, 2019

Conversation

Zdobnov
Copy link
Contributor

@Zdobnov Zdobnov commented Oct 22, 2019

Context

This ticket requires refactoring of the viewer.css file: #11264

What was done

  • border- & box-shadow duplications removed;

@Snuffleupagus
Copy link
Collaborator

refactored all z-index values, as there is no necessity to have such a huge abyss between 10k & 30k (nobody will use 13,876 for example).

That doesn't seem like it belong in this PR, since all of the other changes are essentially "mechanical" and probably won't require that much testing.
There's also the question if we even want to change this, and if so how, since I believe that the z-indexs were purposely implemented such that there's some "space" between them to more easily avoid errors.

@Zdobnov
Copy link
Contributor Author

Zdobnov commented Oct 22, 2019

@Snuffleupagus if it's necessary to implement something new with z-index, between 5 and 10 values there are still 4 steps. In the previous solution values where 199 and 200, and 10k, 20k, etc. at the same moment. It was a bit confused.
Anyway, if that's a problem, I can remove all changes excluding duplications avoiding, just let me know.

@Snuffleupagus
Copy link
Collaborator

Anyway, if that's a problem, I can remove all changes excluding duplications avoiding, just let me know.

As is hopefully clear from #11268 (comment), I obviously think that part should be reverted.
(Also, it's always best if the commit message itself contains all of the information from the PR description.)

@Zdobnov
Copy link
Contributor Author

Zdobnov commented Oct 22, 2019

@Snuffleupagus thank you for advice. I did some changes, now the PR contains only necessary changes, may I ask you to check it?
Thank you.

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/53aa6f1c4af06c5/output.txt

@Snuffleupagus Snuffleupagus mentioned this pull request Oct 22, 2019
@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/53aa6f1c4af06c5/output.txt

Total script time: 1.67 mins

Published

@timvandermeij timvandermeij merged commit 7aca15d into mozilla:master Oct 22, 2019
@timvandermeij
Copy link
Contributor

Thank you for your contribution!

@Zdobnov Zdobnov deleted the refactor/avoid-css-duplication branch October 23, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants