-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert a number of reference tests, for documents with corrupt XRef tables, from load
to eq
#11234
Convert a number of reference tests, for documents with corrupt XRef tables, from load
to eq
#11234
Conversation
…tables, from `load` to `eq` As part of attempting to fix a number issues containing PDF documents with corrupt XRef tables, I'd like to improve the reference test-coverage slightly *first*. Obviously this will increase the runtime of the tests a bit, however I'd rather "waste" resources on the bots instead of developer time fixing regressions which could have been avoided.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/695fde5e1e1eb99/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/aa5a2816a7349af/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/695fde5e1e1eb99/output.txt Total script time: 17.71 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/aa5a2816a7349af/output.txt Total script time: 26.24 mins
|
Test coverage is indeed very important for such changes. Looks good! /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/d452d96f395a4ba/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1dcb5b846217c3a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1dcb5b846217c3a/output.txt Total script time: 16.16 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/d452d96f395a4ba/output.txt Total script time: 23.44 mins
|
As part of attempting to fix a number issues containing PDF documents with corrupt XRef tables, I'd like to improve the reference test-coverage slightly first.
Obviously this will increase the runtime of the tests a bit, however I'd rather "waste" resources on the bots instead of developer time fixing regressions which could have been avoided.