[api-minor] Replace all deprecated calls with throwing of actual Errors
#11219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
throw-deprecated-methods
branch
from
1eb340b to
70bbb94
Compare
…rror`s All of these methods have been marked as `deprecated` in *three* releases now, and I'd thus like to (slowly) move towards complete removal. However rather than just removing the methods right away, which would cause somewhat cryptic failures, this patch tries to implement a hopefully reasonable middle ground by throwing `Error`s with (essentially) the same information as the previous warnings. While the previous `deprecated` messages could perhaps be seen as optional, with these changes API consumers will now be forced to actually migrate their code.
Snuffleupagus
force-pushed
the
throw-deprecated-methods
branch
from
70bbb94 to
ea729ec
Compare
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/629ff7746e65431/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6e7a42cc9252694/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6e7a42cc9252694/output.txt Total script time: 2.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/629ff7746e65431/output.txt Total script time: 4.89 mins
|
timvandermeij
approved these changes
Oct 9, 2019
|
Indeed time to get rid of this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these methods have been marked as
deprecatedin three releases now, and I'd thus like to (slowly) move towards complete removal.However rather than just removing the methods right away, which would cause somewhat cryptic failures, this patch tries to implement a hopefully reasonable middle ground by throwing
Errors with (essentially) the same information as the previous warnings.While the previous
deprecatedmessages could perhaps be seen as optional, with these changes API consumers will now be forced to actually migrate their code.