Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the header size limit of 80 KB #10937

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

timvandermeij
Copy link
Contributor

Fixes #10849.

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/46580a715b2e2fc/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/52314789082e5d6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/46580a715b2e2fc/output.txt

Total script time: 1.18 mins

  • Font tests: FAILED
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/46580a715b2e2fc/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/52314789082e5d6/output.txt

Total script time: 2.35 mins

  • Font tests: FAILED
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/52314789082e5d6/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor Author

The bots run Node.js 10.14.1 and should be updated to use Node.js 10.15.0 since the command line argument used here is backported to that version in the 10.x range. Preferably we update to 10.16.0 though since that is the latest LTS version of Node.js.

/cc @brendandahl @yurydelendik for doing this on both bots

@brendandahl
Copy link
Contributor

./botio test

@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2019

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/429c5cceeb4341d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2019

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/f71e7bdf2b572f2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/429c5cceeb4341d/output.txt

Total script time: 17.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2019

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/f71e7bdf2b572f2/output.txt

Total script time: 60.00 mins

@timvandermeij
Copy link
Contributor Author

/botio-windows test

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2019

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/e8bd7559904c865/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2019

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/e8bd7559904c865/output.txt

Total script time: 25.84 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor Author

timvandermeij commented Jul 4, 2019

Thank you @brendandahl! @Snuffleupagus Could you perhaps review this now that the bots work again?

@timvandermeij timvandermeij merged commit a98ce9c into mozilla:master Jul 5, 2019
@timvandermeij timvandermeij deleted the node-header-size-limit branch July 5, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading error while running gulp makeref
4 participants