-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the header size limit of 80 KB #10937
Restore the header size limit of 80 KB #10937
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/46580a715b2e2fc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/52314789082e5d6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/46580a715b2e2fc/output.txt Total script time: 1.18 mins
Image differences available at: http://54.67.70.0:8877/46580a715b2e2fc/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/52314789082e5d6/output.txt Total script time: 2.35 mins
Image differences available at: http://54.215.176.217:8877/52314789082e5d6/reftest-analyzer.html#web=eq.log |
The bots run Node.js 10.14.1 and should be updated to use Node.js 10.15.0 since the command line argument used here is backported to that version in the 10.x range. Preferably we update to 10.16.0 though since that is the latest LTS version of Node.js. /cc @brendandahl @yurydelendik for doing this on both bots |
./botio test |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/429c5cceeb4341d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f71e7bdf2b572f2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/429c5cceeb4341d/output.txt Total script time: 17.58 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/f71e7bdf2b572f2/output.txt Total script time: 60.00 mins |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e8bd7559904c865/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e8bd7559904c865/output.txt Total script time: 25.84 mins
|
Thank you @brendandahl! @Snuffleupagus Could you perhaps review this now that the bots work again? |
Fixes #10849.