Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clip if path is undefined in SVG back-end #10867

Merged
merged 1 commit into from
May 30, 2019

Conversation

janpe2
Copy link
Contributor

@janpe2 janpe2 commented May 28, 2019

Fixes #10846

The PDF in the issue uses an empty path as the clipping path:

q
    W*
    n
Q

Because of this, display/svg.js attempts to call function cloneNode of an undefined object.

@Snuffleupagus
Copy link
Collaborator

/botio-windows lint
/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/8282dcc3603cddf/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/61539549d60d5b5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/61539549d60d5b5/output.txt

Total script time: 1.88 mins

Published

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/8282dcc3603cddf/output.txt

Total script time: 2.85 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit d0892e4 into mozilla:master May 30, 2019
@timvandermeij
Copy link
Contributor

Thank you!

@janpe2 janpe2 deleted the svg-clip-undefined branch March 10, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'cloneNode' of undefined
4 participants