Ensure that the Cmd/Name/Ref caches are cleared when running other cleanup code
#10863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her `cleanup` code The purpose of these caches is to reduce peak memory usage, by only ever having *a single* instance of a particular object. However, as-is these caches are never cleared and they will thus remain until the worker is destroyed. This could very well have a negative effect on total memory usage, particularly for large/long documents, hence it seems to make sense to clear out these caches together with various other ones.
Snuffleupagus
force-pushed
the
clearPrimitiveCaches
branch
from
bcffe7a to
5e045bc
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/74a979464aee207/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/74a979464aee207/output.txt Total script time: 2.08 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6d69f825b33a92c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1da7d9f72858ffd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6d69f825b33a92c/output.txt Total script time: 17.74 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/1da7d9f72858ffd/output.txt Total script time: 25.65 mins
|
timvandermeij
approved these changes
May 26, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of these caches is to reduce peak memory usage, by only ever having a single instance of a particular object.
However, as-is these caches are never cleared and they will thus remain until the worker is destroyed. This could very well have a negative effect on total memory usage, particularly for large/long documents, hence it seems to make sense to clear out these caches together with various other ones.