Add test for fetch_stream #10715
Add test for fetch_stream #10715
Conversation
test/unit/fetch_stream_spec.js
Outdated
| isStreamingSupported = fullReader.isStreamingSupported; | ||
| isRangeSupported = fullReader.isRangeSupported; | ||
| // We shall be able to close full reader without any issue. | ||
| fullReader.cancel('Don\'t need full reader'); |
There was a problem hiding this comment.
This really ought to be an Error, and not a plain string.
test/unit/fetch_stream_spec.js
Outdated
| @@ -0,0 +1,108 @@ | |||
| /* Copyright 2017 Mozilla Foundation | |||
There was a problem hiding this comment.
This should probably read 2019 :-)
There was a problem hiding this comment.
I think I still live in 2017 😱
mukulmishra18
force-pushed
the
fetch-stream-spec
branch
from
1f128af to
02e46d2
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f8eb2e21ce60988/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1b4137941b70cdb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f8eb2e21ce60988/output.txt Total script time: 2.81 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/1b4137941b70cdb/output.txt Total script time: 5.56 mins
|
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/969b88dc0027838/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/969b88dc0027838/output.txt Total script time: 2.76 mins
|
|
Nice work; thank you for writing more unit tests! |
This PR adds test for
fetch_stream.js. Not sure if we need to add some code for feature detection for native support offetchandReadableStreamfor unit test.Fixes #10671