Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement linear-gradient, radial-gradient and dummy-pattern in SVGGraphics. #10646

Merged
merged 3 commits into from
Mar 17, 2019

Conversation

terurou
Copy link
Contributor

@terurou terurou commented Mar 16, 2019

No description provided.

@terurou terurou marked this pull request as ready for review March 16, 2019 04:31
@timvandermeij
Copy link
Contributor

/botio-linux preview

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f997659b0986c31/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/f997659b0986c31/output.txt

Total script time: 1.82 mins

Published

@timvandermeij timvandermeij merged commit ee3cfb7 into mozilla:master Mar 17, 2019
@timvandermeij
Copy link
Contributor

Thank you for implementing this!

@Snuffleupagus
Copy link
Collaborator

@terurou Please remember to actually squash fix-up commits in the future, as was asked for above, since the result here was that this PR landed with broken intermediate state meaning that e.g. future bisecting will now be a lot more difficult.

@timvandermeij
Copy link
Contributor

You're right. I also forgot to choose the "squash and commit" option on GitHub.

@terurou
Copy link
Contributor Author

terurou commented Mar 17, 2019

@Snuffleupagus Thank you for your advice. I will be careful from the next time.

@terurou terurou deleted the svg-fill branch March 17, 2019 13:31
tamuratak added a commit to tamuratak/pdf.js that referenced this pull request Jan 29, 2020
timvandermeij added a commit that referenced this pull request Jan 29, 2020
Fix the indices of arguments for RadialAxial. It is related to #10646.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants