Convert src/core/parser.js to ES6 syntax and write more unit tests for the lexer and the parser
#10635
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cad120ec4dbf872/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1ebf6751668ff52/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1ebf6751668ff52/output.txt Total script time: 18.00 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/cad120ec4dbf872/output.txt Total script time: 25.95 mins
|
Moreover, disable `var` usage for this file.
Moreover, disable `var` usage for this file.
Moreover, group the lexer unit tests per method. This matches what we do for other classes and makes it more easily visible which methods we don't or insufficiently unit test. The parser itself is not unit tested yet, so this patch provides a start for doing so. The `inlineStreamSkipEI` method is used in other end marker detection methods, so it's important that its functionality is correct for proper parsing.
timvandermeij
force-pushed
the
lexer-parser
branch
from
151237f to
4a4b197
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/40d424052fd6a30/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/2f711fde79bb903/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/40d424052fd6a30/output.txt Total script time: 2.74 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/2f711fde79bb903/output.txt Total script time: 5.51 mins
|
I recommend to review each commit with the
?w=1flag to reduce the size of the diff.