Zero the width/height of the temporary canvas used during TextLayer rendering
#10601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rendering The default size of these canvases seem to be `300 x 150` (two orders of magnitude larger than the ones in PR 10597), which probably is sufficient enough to matter since there's one such canvas for each textLayer that's rendered in the viewer. Also fixes the incorrect rejection reason, i.e. one using a string rather than an `Error`, in the `TextLayerRenderTask.cancel` method.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/28accb05499c9b9/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0e6f5b8b1925903/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0e6f5b8b1925903/output.txt Total script time: 18.13 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/28accb05499c9b9/output.txt Total script time: 25.64 mins
|
timvandermeij
approved these changes
Mar 1, 2019
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default size of these canvases seem to be
300 x 150(two orders of magnitude larger than the ones in PR #10597), which probably is sufficient enough to matter since there's one such canvas for each textLayer that's rendered in the viewer.Also fixes the incorrect rejection reason, i.e. one using a string rather than an
Error, in theTextLayerRenderTask.cancelmethod.