Fix missing moveTos in SVG paths #10590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2764d70a583bf5f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2764d70a583bf5f/output.txt Total script time: 1.96 mins Published |
timvandermeij
approved these changes
Mar 2, 2019
|
Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
OperatorListsplits page contents into chunks of 1000 operators, some paths may be divided into twoOPS.contructPathoperators. The canvas back-end has no problems but the SVG back-end produces two<svg:path>elements and the latter one doesn't start with a moveTo command. Firefox doesn't draw this kind of SVG paths and Chrome logs an error in the console.My idea is to append path commands to the same
<svg:path>element until the path is terminated by a painting operator, likeforS. It's the standard PDF behavior that painting operators finish and end the current path.Fixes #9167
Fixes #10522
Also issue #10282 seems to have this problem. Now a missing line segment is easily visible in the top-right corner of the page
