Avoid truncating/breaking some Type3 glyphs in compileType3Glyph (bug 1245391, issue 10568)
#10573
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c3f53e107560231/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/916b32c1869a1ff/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c3f53e107560231/output.txt Total script time: 18.01 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/916b32c1869a1ff/output.txt Total script time: 26.04 mins
|
|
@brendandahl Could you perhaps check this? |
…ug 1245391, issue 10568) *Hopefully this patch makes sense, since I cannot claim to fully understand this function.* With the changes made in PR 3354 *some* Type3 glyph outlines are no longer rendering correctly, since the final paths were being accidentally ignored. The fact that Type3 fonts are not very common in PDF documents, and that most Type3 glyphs are unaffected by this regression, probably explains why this has gone unnoticed since 2013.
Snuffleupagus
force-pushed
the
type3-avoid-truncation
branch
from
97c2c41 to
fb774a6
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1f7a1ec796808d9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/90d9fa47ae8842a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1f7a1ec796808d9/output.txt Total script time: 17.94 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/90d9fa47ae8842a/output.txt Total script time: 25.86 mins
|
timvandermeij
requested review from
yurydelendik
and removed request for
brendandahl
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e6253cffd39a597/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e6253cffd39a597/output.txt Total script time: 1.86 mins Published |
|
@yurydelendik Gentle review ping; is the updated patch OK? |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e638f8a3b98afae/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9ecb6c847ed7811/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e638f8a3b98afae/output.txt Total script time: 16.42 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9ecb6c847ed7811/output.txt Total script time: 22.90 mins
|
Hopefully this patch makes sense, since I cannot claim to fully understand this function.
With the changes made in PR #3354 some Type3 glyph outlines are no longer rendering correctly, since the final paths were being accidentally ignored.
The fact that Type3 fonts are not very common in PDF documents, and that most Type3 glyphs are unaffected by this regression, probably explains why this has gone unnoticed since 2013.
Fixes bug 1245391
Fixes #10568