-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-factor the PDFDataRangeTransport
unit-tests and enable them in Node.js/Travis
#10558
Re-factor the PDFDataRangeTransport
unit-tests and enable them in Node.js/Travis
#10558
Conversation
…tor `NodeFileReaderFactory` to be asynchronous This allows simplification of the 'creates pdf doc from URL and aborts loading after worker initialized' API unit-test. Note that the `DOMFileReaderFactory` uses the Fetch API, for simplicity, since it should be available in all browsers where we're running tests.
…ode.js/Travis There doesn't appear to be any particular reason for only running these unit-tests in browsers, since the `PDFDataRangeTransport` functionality itself should be back-end agnostic.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/327d8bff7a44e5e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6f3a1e6e532fc0b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/327d8bff7a44e5e/output.txt Total script time: 2.84 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6f3a1e6e532fc0b/output.txt Total script time: 5.33 mins
|
Thank you for doing this! |
Thanks for the very quick review! I believe that we're now running all the possible unit-tests in Node.js/Travis, with the sole exception of Lines 656 to 672 in ff74a66
|
There doesn't appear to be any particular reason for only running these unit-tests in browsers, since the
PDFDataRangeTransport
functionality itself should be back-end agnostic.