Fix getVisibleElements helper in RTL-locales

mozilla · Oct 9, 2020 · e1cadbe · e1cadbe
1 parent 88f72d6
commit e1cadbe
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/web/ui_utils.js b/web/ui_utils.js
@@ -465,11 +465,13 @@ function getVisibleElements(
       element.offsetTop + element.clientTop + element.clientHeight;
     return elementBottom > top;
   }
-  function isElementRightAfterViewLeft(view) {
+  function isElementNextAfterViewHorizontally(view) {
     const element = view.div;
+    const elementLeft =
+      element.offsetLeft + element.clientLeft;
     const elementRight =
-      element.offsetLeft + element.clientLeft + element.clientWidth;
-    return elementRight > left;
+      elementLeft + element.clientWidth;
+    return document.dir === "rtl" ? elementLeft < right : elementRight > left;
   }
 
   const visible = [],
@@ -479,7 +481,7 @@ function getVisibleElements(
       ? 0
       : binarySearchFirstItem(
           views,
-          horizontal ? isElementRightAfterViewLeft : isElementBottomAfterViewTop
+          horizontal ? isElementNextAfterViewHorizontally : isElementBottomAfterViewTop
         );
 
   // Please note the return value of the `binarySearchFirstItem` function when