Skip to content

Commit

Permalink
Merge pull request #15603 from Snuffleupagus/pr-15593-followup
Browse files Browse the repository at this point in the history
Restore a weaker version of the /Pages dictionary /Count check for corrupt documents (PR 15593 follow-up)
  • Loading branch information
Snuffleupagus authored Oct 20, 2022
2 parents 36967fc + e591378 commit 7dc16c2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
7 changes: 6 additions & 1 deletion src/core/xref.js
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ class XRef {
continue;
}
// Do some basic validation of the trailer/root dictionary candidate.
let validPagesDict = false;
try {
const rootDict = dict.get("Root");
if (!(rootDict instanceof Dict)) {
Expand All @@ -591,13 +592,17 @@ class XRef {
if (!(pagesDict instanceof Dict)) {
continue;
}
const pagesCount = pagesDict.get("Count");
if (Number.isInteger(pagesCount)) {
validPagesDict = true;
}
// The top-level /Pages dictionary isn't obviously corrupt.
} catch (ex) {
trailerError = ex;
continue;
}
// taking the first one with 'ID'
if (dict.has("ID")) {
if (validPagesDict && dict.has("ID")) {
return dict;
}
// The current dictionary is a candidate, but continue searching.
Expand Down
6 changes: 1 addition & 5 deletions test/driver.js
Original file line number Diff line number Diff line change
Expand Up @@ -553,11 +553,7 @@ class Driver {
if (!task.pdfDoc) {
return task.firstPage || 1;
}
let lastPageNumber = task.lastPage || 0;
if (!lastPageNumber || lastPageNumber > task.pdfDoc.numPages) {
lastPageNumber = task.pdfDoc.numPages;
}
return lastPageNumber;
return task.lastPage || task.pdfDoc.numPages;
}

_nextPage(task, loadError) {
Expand Down

0 comments on commit 7dc16c2

Please sign in to comment.