Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enforce immutability #4

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Sep 2, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.55%. Comparing base (c732bd2) to head (0ef2797).

Files with missing lines Patch % Lines
src/lib.rs 90.90% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   93.43%   94.55%   +1.12%     
==========================================
  Files           1        1              
  Lines         198      202       +4     
==========================================
+ Hits          185      191       +6     
+ Misses         13       11       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert
Copy link
Collaborator

larseggert commented Sep 2, 2024

Might also want to do this for the Windows addr_table and if_table pointers?

@mxinden
Copy link
Collaborator Author

mxinden commented Sep 2, 2024

I updated the windows implementation to use early returns like the unix implementation does. Let me know if you prefer the immutability change only.

@mxinden mxinden changed the title refactor: enforce immutability of ifap refactor: enforce immutability Sep 2, 2024
@larseggert larseggert merged commit 2c65c4a into mozilla:main Sep 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants