-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zoom views (DENG-6964) #1159
base: main
Are you sure you want to change the base?
Conversation
The current generate-lookml CI error is likely because the views authorizations haven't been applied by data infra automation yet. I'll retry the CI tomorrow when the view authorizations will hopefully be in place. |
glean_app: false | ||
views: | ||
meetings: | ||
type: table_view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to also generate table_explore
s for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan is to have one main "meetings" explore joining several of these views together, and a "users" explore just on the users
view. So while I could add a table_explore
for the latter here, I figured since I'll be needing to do a looker-spoke-default PR for the other explore I'd just do both that way.
The @scholtzan do you have any advice on the best way to proceed here? Two ideas that come to mind are:
|
I thought we had some logic in place already to ignore permission errors... |
It should hit this:
|
Maybe the issue is that the original lookml-generator/generator/views/datagroups.py Lines 146 to 149 in aef6b53
|
This should fix it: #1161 |
DENG-6964: Integrate Zoom into BigQuery/Looker using FiveTran (API)
After this is deployed I plan to manually add explores joining these views together in looker-spoke-default.