Fix Windows builds #256
Fix Windows builds #256
Conversation
We were using Rust beta as some features we were relying on were only available there, most notably cross-compilation. Now that beta has been rolled into stable, we are able to rely on the stable channel for most of our targets.
As of 2016-09-21 Travis started serving Ubuntu precise containers when trusty was requested. This caused the x86_64-pc-windows-gnu build to break, but we only noticed when building on custom Travis branches because the geckodriver master branch used a cached Rust installation. This change reverts the 64-bit Windows builds to run outside of the container infrastructure, in which we can guarantee we are served Ubuntu trusty with a sufficiently modern gcc to cross-compile.
gcc-mingw-w64 is implied by gcc-mingw-w64-x86-64.
|
I think a future improvement to this would be to provide our own Dockerfile descriptions of what we want to build as they are no slower than bare metal builds. This would allow us to move some of the dependency installation out of .travis.yml and build.sh, into the Dockerfiles. This would particularly benefit one-off components such as the custom mingw thing we need to link for 32-bit Windows. |
|
Anyway, despite the above, I think this solves our immediate problems in no worse way than before. r? @jgraham |
|
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 4 of 4 files at r4. build.sh, line 28 at r4 (raw file):
It's not really clear what this is doing, or why it's only doing it if !DOCKER && i686 (for example it seems like linux32 would not want it, if we added that). Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. build.sh, line 28 at r4 (raw file):
|
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. build.sh, line 28 at r4 (raw file):
|
By setting up our own container we can share the build.sh file (almost) fully between containerised- and bare metal builds. The apt dependencies needed are listed in i686-trusty/Dockerfile. We build i686-pc-windows-gnu in a custom container because the Ubuntu trusty VM provided by Travis does not have a sufficiently modern gcc compiler.
|
Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion. build.sh, line 28 at r4 (raw file):
|
|
Reviewed 1 of 1 files at r5. Comments from Reviewable |
Fixes #246.
This change is