-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1642484 [wpt PR 23900] - Remove MainThreadScrollingReasons::kHasC…
…lipRelatedProperty, a=testonly Automatic update from web-platform-tests Remove MainThreadScrollingReasons::kHasClipRelatedProperty We no longer need to skip composited scrolling for css clip and clip-path since (perhaps) BlinkGenPropertyTrees. In compositor, when we hit test on a layer with special clip/mask, we'll still fallback to main thread hit testing/scrolling because only the main thread knows which area is hit testable. This is achieved by cc::LayerTreeHostImpl::IsInitialScrollHitTestReliable() returning false. Bug: 1074395 Change-Id: I91260b063879812ca82928fe783de25c4b6732a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225229 Commit-Queue: Xianzhu Wang <[email protected]> Reviewed-by: Philip Rogers <[email protected]> Reviewed-by: Robert Flack <[email protected]> Reviewed-by: David Bokan <[email protected]> Cr-Commit-Position: refs/heads/master@{#774232} -- wpt-commits: 4c2484a55b58a72b74c0b6c55ab0238cf11efb4a wpt-pr: 23900 Differential Revision: https://phabricator.services.mozilla.com/D78793
- Loading branch information
1 parent
d3e2121
commit 69ab27a
Showing
4 changed files
with
58 additions
and
0 deletions.
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
testing/web-platform/tests/css/css-masking/clip-path/clip-path-scroll.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<!DOCTYPE html> | ||
<title>CSS Masking: Test clip-path property with overflow:scroll</title> | ||
<link rel="help" href="http://www.w3.org/TR/css-masking-1/#clip-path-property"> | ||
<link rel="match" href="reference/clip-path-scroll-ref.html"> | ||
<html class="reftest-wait"> | ||
<p>The test passes if there is a green square containing text (which can be scrolled | ||
with mouse wheel or touch). No scrollbars should be seen.</p> | ||
<div id="target" style="clip-path: polygon(10px 10px, 10px 100px, 100px 100px, 100px 10px); | ||
width: 200px; height: 200px; overflow: scroll; background: red"> | ||
<div style="position: relative; top: 100px; | ||
width: 100px; height: 100px; background: green"> | ||
</div> | ||
<div style="height: 1000px"></div> | ||
</div> | ||
<script> | ||
requestAnimationFrame(() => { | ||
requestAnimationFrame(() => { | ||
target.scrollTop = 100; | ||
document.documentElement.classList.remove("reftest-wait"); | ||
}); | ||
}); | ||
</script> | ||
</html> | ||
|
5 changes: 5 additions & 0 deletions
5
testing/web-platform/tests/css/css-masking/clip-path/reference/clip-path-scroll-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<!DOCTYPE html> | ||
<p>The test passes if there is a green square containing text (which can be scrolled | ||
with mouse wheel or touch). No scrollbars should be seen.</p> | ||
<div style="position: relative; top: 10px; left: 10px; width: 90px; height: 90px; background: green"> | ||
</div> |
24 changes: 24 additions & 0 deletions
24
testing/web-platform/tests/css/css-masking/clip/clip-rect-scroll.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<!DOCTYPE html> | ||
<title>CSS Masking: Test clip property with rect function with overflow:scroll</title> | ||
<link rel="help" href="http://www.w3.org/TR/css-masking-1/#clip-property"> | ||
<link rel="match" href="reference/clip-rect-scroll-ref.html"> | ||
<html class="reftest-wait"> | ||
<p>The test passes if there is a green square containing text (which can be scrolled | ||
with mouse wheel or touch). No scrollbars should be seen.</p> | ||
<div id="target" style="position: absolute; clip: rect(10px,100px,100px,10px); | ||
width: 200px; height: 200px; overflow: scroll; background: red"> | ||
<div style="position: relative; top: 100px; | ||
width: 100px; height: 100px; background: green"> | ||
</div> | ||
<div style="height: 1000px"></div> | ||
</div> | ||
<script> | ||
requestAnimationFrame(() => { | ||
requestAnimationFrame(() => { | ||
target.scrollTop = 100; | ||
document.documentElement.classList.remove("reftest-wait"); | ||
}); | ||
}); | ||
</script> | ||
</html> | ||
|
5 changes: 5 additions & 0 deletions
5
testing/web-platform/tests/css/css-masking/clip/reference/clip-rect-scroll-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<!DOCTYPE html> | ||
<p>The test passes if there is a green square containing text (which can be scrolled | ||
with mouse wheel or touch). No scrollbars should be seen.</p> | ||
<div style="position: relative; top: 10px; left: 10px; width: 90px; height: 90px; background: green"> | ||
</div> |