Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & Delete Metrics Pages #833

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Update & Delete Metrics Pages #833

merged 7 commits into from
Jun 4, 2024

Conversation

jmsilverman
Copy link

@jmsilverman jmsilverman commented Jun 3, 2024

There are multiple Metrics-related pages that are very out of date in DTMO:

This PR removes the child pages and adds a link to the parent page to a single source of truth for metrics, which is the Metrics Inventory in Confluence.

This is part of DS-3616.

@jmsilverman jmsilverman marked this pull request as ready for review June 3, 2024 23:50
Copy link
Contributor

@bani bani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have some broader discussions next week about the pros and cons of having open documentation and for which areas it's more important.

@jmsilverman
Copy link
Author

jmsilverman commented Jun 4, 2024

@bani I think it'd be great to discuss this next week all together in Toronto, but the agenda is pretty full already (though we might be able to find some time to chat about it). I'll also point out that we have yet another a public-facing DAU description that is out of date: https://data.firefox.com/dashboard/user-activity (as well as a Jira ticket to fix that)

Copy link
Contributor

@bochocki bochocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems useful imo to clean up stale information and reduce the number of pages we need to maintain. It's worth having the conversation @bani mentioned though. It's possible we can do both -- have a single source of truth for documentation that is also publicly available.

Maybe it's worth talking about at the Methodology Working Group?

@jmsilverman
Copy link
Author

jmsilverman commented Jun 4, 2024

After chatting about this at the Methodology Working Group meeting today it seems like we're agreed that it's OK to remove these pages. Also, on the metrics page, in addition to the link to Confluence's Metrics Inventory page, I added a link to metric-hub code in github (which is publicly accessible).

I also edited the Terminology entry for DAU slightly.

@bochocki bochocki self-requested a review June 4, 2024 21:52
@jmsilverman jmsilverman merged commit 16f7683 into main Jun 4, 2024
9 checks passed
@jmsilverman jmsilverman deleted the update-metrics-page branch June 4, 2024 21:53
badboy added a commit that referenced this pull request Sep 11, 2024
@badboy badboy mentioned this pull request Sep 11, 2024
badboy added a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants