-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DS-2284, DS-2520)Creating Relay derived tables and views for Relay SaaSboard #3482
Conversation
Integration report for "added country_name columns to all tables"
|
Integration report for "reformat query files for circle ci error fixing"
|
Integration report for "Merge branch 'main' into yeonjoo_relay_saasboard_mvp"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of additional changes to make:
- This is missing a
schema.yaml
file forrelay_derived.active_subscription_ids_v1
. sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/query.sql
should be added to the "Access Denied" section ofbigquery_etl/dryrun.py
, because the account that does the dry runs won't have permission to query the Stripe tables.
sql/moz-fx-data-shared-prod/relay_derived/active_subscriptions_live/view.sql
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscription_events_live/view.sql
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscription_events_v1/query.sql
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/metadata.yaml
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/query.sql
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/query.sql
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/query.sql
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/query.sql
Outdated
Show resolved
Hide resolved
Integration report for "Schema edited and dry run list updated"
|
Co-authored-by: Sean Rose <[email protected]>
Co-authored-by: Sean Rose <[email protected]>
Integration report for "removing status column in multiple places"
|
Integration report for "matching date_partition_offset setting with the table"
|
Integration report for "keep the consistency of friendly_name"
|
Integration report for "removing unnecessary comment"
|
First round of revisions are done. Let me know if there is anything to be changed before the approval. |
Integration report for "subscriptions query updated"
|
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/query.sql
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/schema.yaml
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/schema.yaml
Outdated
Show resolved
Hide resolved
sql/moz-fx-data-shared-prod/relay_derived/subscriptions_v1/schema.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Rose <[email protected]>
Integration report for "subscriptions_v1 schema editted"
|
Integration report for "Merge branch 'main' into yeonjoo_relay_saasboard_mvp"
|
Integration report for "add "relay-phones" to be included for filtering"
|
event_type, | ||
granular_event_type, | ||
plan_id, | ||
country, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out this also needed to group by country_name
. I've submitted #3495 to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I've backfilled the tables created by this PR:
|
Tried to mimic the data structure of mozilla vpn derived dataset to use the derived tables for Relay SaaSboard MVP
The attributions and some other parts in the vpn all subscriptions table are not included in the relay subscriptions table for simplicity for now. Please refer to commented out column names in subscriptions_v1 query.
There were error messages for using the bqetl tools to automatically validate and update schema and the error messages (in my understanding) were due to the creation of new files(nothing to compare against). But I was able to use the generate dag function to update the dag file.
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):