Evolve enrollment error handling sdk-294 #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #4186 +/- ##
===========================================
+ Coverage 64.42% 74.89% +10.46%
===========================================
Files 56 44 -12
Lines 4613 4015 -598
===========================================
+ Hits 2972 3007 +35
+ Misses 1641 1008 -633
Continue to review full report at Codecov.
|
dmose
commented
Jun 15, 2021
travis79
approved these changes
Jun 15, 2021
| ) { | ||
| Ok(enrollment) => enrollment, | ||
| Err(e) => { | ||
| log::error!("evolve_enrollment(\n\tprev_exp: {:?}\n\t, next_exp: {:?}, \n\tprev_enrollment: {:?})\n\t returned an error: {}; dropping this record", prev_experiments.get(slug).copied(), Some(next_experiments.get(slug).copied()), prev_enrollment, e); |
travis79
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the evolve_enrollments error handling to discard invalid records, rather than simplying blowing up and letting the error propagate up the stack.
It has an integration test for apply_updates. I thought about writing one for set_global_opt_out, but I'm not convinced it provides much additional information, at least as relevant to this patch. Which is to say that there shouldn't be errors that such a test would catch that this patch fixes and wouldn't already be caught by the apply_updates integration test.
Pull Request checklist
[ci full]to the PR title.