Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Xcode 10.2.1, Swift 4.2 (from 4.0). #1088

Merged
merged 1 commit into from
May 6, 2019

Conversation

garvankeeley
Copy link
Contributor

Update the Circle CI script and the common.xcconfig.

This will land along with mozilla-mobile/firefox-ios#4842 to bump FxiOS to the latest Xcode.

@garvankeeley garvankeeley requested a review from eoger April 26, 2019 16:19
Copy link
Contributor

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo 1 nit, does this mean we should update our local versions of xcode?

- run: brew install swiftlint swiftformat
- run: swiftlint --strict
- run: swiftformat --lint --swiftversion 4 --verbose megazords
# DISABLED DUE TO https://bit.ly/2ZBqkEK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer the actual URL

@eoger eoger added the Blocked label Apr 26, 2019
@eoger
Copy link
Contributor

eoger commented Apr 26, 2019

Blocked on CircleCI releasing 10.2.1

@garvankeeley
Copy link
Contributor Author

A christmas miracle in May: https://discuss.circleci.com/t/xcode-10-2-1-image-released
I'll update this PR.

@garvankeeley garvankeeley force-pushed the garvan/xcode--10.2 branch 2 times, most recently from 8ae5ce2 to cd27dde Compare May 6, 2019 15:12
@garvankeeley garvankeeley merged commit 0932bd5 into mozilla:master May 6, 2019
@rfk rfk mentioned this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants