Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Document version numbers #2647

Closed
ianb opened this issue Apr 11, 2017 · 2 comments
Closed

Document version numbers #2647

ianb opened this issue Apr 11, 2017 · 2 comments
Assignees

Comments

@ianb
Copy link
Contributor

ianb commented Apr 11, 2017

We have a version number in package.json. We should document how it is managed. Proposal:

  • Every time we release we increment the number (in development) to a new number. E.g., release 6.x (to the Firefox tree) and we increment to 7.0.0
  • Every time we do a stage release, we increment the second number in advance of that release. I.e., 7.1.0, and if 7.1.0 fails then 7.2.0, etc.
  • Every time we release to Firefox we increment the third number one more time, so that version is bigger than any in-development version. I.e., if 7.2.0 is all good, we increment to 7.3.0 for export, and then immediately change our in-development version to 8.0.0.
  • In-development builds use the third number as a date timestamp, i.e., 7.1.20170411
@ghost ghost added this to the Stretch milestone Apr 12, 2017
@jaredhirsch jaredhirsch modified the milestones: Screenshots in 54, Stretch May 9, 2017
@jaredhirsch
Copy link
Member

Got burned by this, incrementing patch version numbers between 6.6.0 and 6.6.2 as part of performance tweaking for the 54 release :-(

Promoting into the 54 milestone to prevent similar mistakes in the future

@jaredhirsch
Copy link
Member

oh wait, maybe we can just do this third thing:

Every time we release to Firefox we increment the third number one more time, so that version is bigger than any in-development version. I.e., if 7.2.0 is all good, we increment to 7.3.0 for export, and then immediately change our in-development version to 8.0.0.

jaredhirsch added a commit that referenced this issue May 26, 2017
Following our version numbering scheme
#2647
@ianb ianb mentioned this issue Jun 5, 2017
12 tasks
@ianb ianb self-assigned this Jun 9, 2017
ianb added a commit that referenced this issue Jun 9, 2017
All the other information in #2647 is implicit in the release checklist
@ianb ianb mentioned this issue Jun 12, 2017
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants