Apply version checks to add-ons and plugins in the blocklist

[gijsk]

@leplatrem could you have a look at this? python is very far from the language I'm most comfortable with, so please review mercilessly and I will try to update this PR quickly. :-)

[leplatrem]

It looks good! Only a few comments :)

I personally don't like the naming style of variables/functions, but your changes are consistent with the rest...

Note: If you want to get rid of the failing tests, you can remove the pytest-sugar package from the dev requirements.

[leplatrem]

targetApplication = vR.get('targetApplication')
if not targetApplication:
    return None
for tA in targetApplication:
    ....

[gijsk]

Ah, good point, thanks. :-)

[leplatrem]

There used to be a or 'guid' not in targetApplication in the previous code. Maybe you want to do tA.get('guid') instead (to avoid KeyError and obtain None)

[leplatrem]

can't we use is_related_to() here?

[gijsk]

I tried this first, but it didn't work, which is why I factored out part of is_related_to(). The problem is you can invoke add_plugin_item both with and without a targetApplication. Iff you pass one, it includes information from that targetApplication into the bit it writes out into blocklist.xml. In other words, when I did that, the tests failed. :-)

[gijsk]

As for pytest-sugar, I pinned the pytest dependency locally based on pytest-dev/pytest#3170 (comment) . I assumed I shouldn't touch it in the repo. Do you want me to remove pytest-sugar in the dev-requirements as part of this PR?

[Natim]

I would be in favor of pinning pytest rather than removing pytest-sugar until pytest-sugar is fixed.

[gijsk]

@leplatrem can you check if this matches what you expected? :-)

[leplatrem]

@leplatrem can you check if this matches what you expected? :-)

All good!