Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Only try to unbound the Daemon if it exists #9465

Merged
merged 1 commit into from
May 8, 2024
Merged

Nit: Only try to unbound the Daemon if it exists #9465

merged 1 commit into from
May 8, 2024

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Apr 30, 2024

Description

In case we kill the activity before the serviceconnection is valid, for example when writing speedy integration tests,
this will cause a crash :)

@strseb strseb requested review from brizental and mcleinman April 30, 2024 13:11
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@strseb strseb enabled auto-merge (squash) May 2, 2024 14:27
@github-actions github-actions bot added the 🛬 Landing This PR is marked as "auto-merge" label May 2, 2024
@strseb strseb merged commit 5b0edb0 into main May 8, 2024
114 checks passed
@strseb strseb deleted the basti/nit branch May 8, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛬 Landing This PR is marked as "auto-merge"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants