Make Android auto default excluded #9344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
approved these changes
Apr 9, 2024
brizental
reviewed
Apr 9, 2024
Co-authored-by: Beatriz Rizental <[email protected]>
src/settingslist.h
Outdated
| @@ -654,7 +654,14 @@ SETTING_STRINGLIST(vpnDisabledApps, // getter | |||
| removeVpnDisabledApps, // remover | |||
| hasVpnDisabledApps, // has | |||
| "vpnDisabledApps", // key | |||
| QStringList(), // default value | |||
| #ifdef MZ_ANDROID | |||
| QStringList{ | |||
There was a problem hiding this comment.
Suggested change
| QStringList{ | |
| QStringList{ |
There was a problem hiding this comment.
I think this is all we need to make the linter happy
lesleyjanenorton
approved these changes
Apr 10, 2024
src/settingslist.h
Outdated
| @@ -654,7 +654,14 @@ SETTING_STRINGLIST(vpnDisabledApps, // getter | |||
| removeVpnDisabledApps, // remover | |||
| hasVpnDisabledApps, // has | |||
| "vpnDisabledApps", // key | |||
| QStringList(), // default value | |||
| #ifdef MZ_ANDROID | |||
| QStringList{ | |||
There was a problem hiding this comment.
I think this is all we need to make the linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been asked to add this to be default excluded .