-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPN-5855 - Part 2 - Update TaskGetFeatureList to use new Guardian endpoint and scheduling #8956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
changed the title
VPN-5855 - Update TaskGetFeatureList to use new Guardian endpoint and scheduling
VPN-5855 - Part 2 - Update TaskGetFeatureList to use new Guardian endpoint and scheduling
Jan 15, 2024
brizental
commented
Jan 17, 2024
brizental
force-pushed
the
5855-get-experiments
branch
from
January 17, 2024 10:17
0be6513
to
2deb52e
Compare
vinocher
reviewed
Jan 19, 2024
vinocher
reviewed
Jan 24, 2024
vinocher
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
brizental
force-pushed
the
5855-get-experiments
branch
from
January 25, 2024 15:08
6193930
to
e9ebe70
Compare
Merging this is blocked until https://github.com/mozilla-services/guardian-website/pull/1688 is merged and released to staging. |
brizental
added
the
⛔️ do not merge ⛔️
This PR should not be included in the current/next release
label
Jan 25, 2024
brizental
force-pushed
the
5855-get-experiments
branch
2 times, most recently
from
February 5, 2024 15:29
1f25f30
to
ed37b95
Compare
brizental
removed
the
⛔️ do not merge ⛔️
This PR should not be included in the current/next release
label
Feb 5, 2024
brizental
force-pushed
the
5855-get-experiments
branch
from
May 2, 2024 15:04
ed37b95
to
3fff341
Compare
brizental
force-pushed
the
5855-get-experiments
branch
from
May 3, 2024 08:13
c412078
to
85a66e5
Compare
strseb
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/featurelist
Guardian enpoint is being update to also return experimental features from Nimbus, see https://github.com/mozilla-services/guardian-website/pull/1688.This pull request updates TaskGetFeatureList to use the new endpoint. The new enpoint
This pull request also updates the scheduling of the calls to this endpoint. Previously this endpoint would only be called once the user was logged in, on a timer. Now it should be called
About the experimenter id
The experimenter id is used by Nimbus to calculate the experimental features that should be enable and with which parameters.
As described in https://github.com/mozilla-mobile/mozilla-vpn-client/blob/main/docs/rfcs/0006-cirrus-experiments.md, we will use the FxA id as the experimenter id. However, if the user is logged out we will generate a random UUID and use that instead.
Therefore, whenever the user logged in state changes TaskGetFeatureList needs to be re-run with a different experimenter id. Note that the way this is implemented, the logged out experimenter id is only calculated once i.e. it doesn't get recalculated everytime the user logs out. As I write this I realize we should probably rotate it as well when telemetry is disabled -- will send a commit with that.