Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-6813 fix translation in install string #10208

Merged
merged 1 commit into from
Jan 21, 2025
Merged

VPN-6813 fix translation in install string #10208

merged 1 commit into from
Jan 21, 2025

Conversation

mcleinman
Copy link
Collaborator

@mcleinman mcleinman commented Jan 21, 2025 •
edited
Loading

Description

See diagnosis on the ticket. I'm the one who broke this in #9641.

Reference

VPN-6813

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman marked this pull request as draft January 21, 2025 22:36
lesleyjanenorton
lesleyjanenorton approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcleinman mcleinman marked this pull request as ready for review January 21, 2025 23:16
@mcleinman mcleinman merged commit 262e6db into main Jan 21, 2025
117 checks passed
@mcleinman mcleinman deleted the vpn-6813-fix-install-string branch January 21, 2025 23:16
mcleinman added a commit that referenced this pull request Jan 21, 2025
@mcleinman
VPN-6813 fix translation (#10208)
000b273
@mcleinman mcleinman mentioned this pull request Jan 21, 2025
Merged
lesleyjanenorton pushed a commit that referenced this pull request Jan 21, 2025
@mcleinman
VPN-6813 fix translation (#10208) (#10209)
c75990c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesleyjanenorton lesleyjanenorton lesleyjanenorton approved these changes

@oskirby oskirby Awaiting requested review from oskirby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcleinman @lesleyjanenorton