[Bug] replace GamePlayKit with aStar for path finding

[ampm]

Hi @garvankeeley @jhugman , can you help to review this PR and to see if it is possible to merge it back into master branch?

Checkpoints

• have tested it and now the pathfinding works stable.
• Test with FireFox-iOS: SmokeTest works as well as with GamePlayKit(except of testAccountManagementPage, this case failed because of the code itself).

Test Result

Description

This PR has resolved #16

• Remove GamePlayKit
• Replace it with aStar
  The implementation of aStar algorithm is borrowed from @Dev1an https://github.com/Dev1an/A-Star (MIT license)

Rewind

One more thing I want to share with you is, in this branch(for reproducing the bug, if you remember)

https://github.com/ampm/MappaMundi/blob/ampm/reproduce_finpath_bug/

We repeatedly run testReproduceFindpathError ten times with the following code, and our app will relaunch before each invokes, we can reproduce the error easily, the right or wrong result comes alternatively.

override func invokeTest() {
       for time in 0...10 {
           print("this test is invoking: \(time) times")
           super.invokeTest()
       }
   }
   func testReproduceFindpathError() {
       navigator.nowAt(Screens.itemDetail)
       navigator.goto(Screens.foo5)
   }

But if we repeat it in this way(we run the test manually),

• if the path is incorrect at the first loop, it will show us with 10 mistakes.
• in a similar way, it will show us with 10 right results consistently if the path is right from begging.

func testReproduceFindpathError() {
       for _ in 0...10 {
           navigator.nowAt(Screens.itemDetail)
           navigator.goto(Screens.foo5)
       }
   }

[Dev1an]

Hello @ampm
Nice to hear that you are using my A* implementation. If you are interested, I made an SPM package that you can now easily depend upon using Xcode 11.

I also updated the code to use the new hashing function.

[garvankeeley]

Hopefully we can upgrade to Xcode 11 in the coming months, but we want this project to be compatible with the build macs for Firefox iOS which is currently limited to Xcode 10.

[garvankeeley]

Can you change the inclusion of A* to use:
Cartfile:

github "Dev1an/A-Star" "master"

Assuming 'master' is the working version here.
and add the Cartfile.resolved

Then include Carthage/Checkouts/A-Star/[the needed files] swift files in the mappamundi project as they are currently.

[garvankeeley]

Please use the mozilla licence header, thanks

[ampm]

sure, updated.

[Dev1an]

I added a version tag so you can safely use all versions compatible with version 1.0.0
Cartfile:

github "Dev1an/A-Star" ~> 2.0.0

[ampm]

Can you change the inclusion of A* to use:
Cartfile:

github "Dev1an/A-Star" "master"

Assuming 'master' is the working version here.
and add the Cartfile.resolved

Then include Carthage/Checkouts/A-Star/[the needed files] swift files in the mappamundi project as they are currently.

Hi @garvankeeley , have integrated with Carthage.

[ampm]

Hi @garvankeeley, have updated code, pls help to review it again, thanks.
Really appreciate @Dev1an's help.

[ampm]

hi @garvankeeley, pls on hold, I need to do more test to make sure it works well with FireFox-iOS.

[garvankeeley]

I'll run all the Firefox iOS tests with this today and see how it goes.

[ampm]

I'll run all the Firefox iOS tests with this today and see how it goes.

sure, but pls let me know before merging, because of the Astar source code in MappamMundi is a little different with the version specified in Carhtage/Carthage.resolve files. (I copied them instead of using the checked out source at this moment.)

I have created a PR for it and waiting for @Dev1an to review it. Dev1an/A-Star#7 . once it is merged, I can update the Carthage file in this PR and link checked files into this project.

[garvankeeley]

I'll wait until your PR is merged. For now, the test results are looking good on Firefox iOS.

[garvankeeley]

Mind if I ping for a status update on this PR?

[ampm]

hi @garvankeeley , it's ready to merge now.

To apply this update in FireFox-iOS, I can create another PR with following actions for it.

1. add the dependency of
github "Dev1an/A-Star" ~> 3.0.0-beta-1
2. add the build output AStar.framework into the link binaries build phase of

• L10nSnapshotTests
• XCUITests

Thanks a lot.

[garvankeeley]

I'll land this and then update Firefox iOS.