Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

change carthage refs and documentation for xcode 10.2 #946

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Conversation

sashei
Copy link
Contributor

@sashei sashei commented Apr 30, 2019

Fixes #914
Connected to #945

@sashei sashei requested a review from a team as a code owner April 30, 2019 19:45
Copy link
Contributor

@linuxwolf linuxwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

pending the follow up issue (if needed)

@@ -6,7 +6,7 @@ github "RxSwiftCommunity/RxOptional" ~> 3.1.3
github "mozilla-mobile/telemetry-ios"
github "jrendel/SwiftKeychainWrapper" ~> 3.0
github "mozilla-mobile/MappaMundi" "master"
github "mozilla/application-services" "v0.22.1"
github "garvankeeley/application-services" "0.27.0.1" # for xcode 10.2 compat use this fork temporarily
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there already an issue to track changing this "back" to mozilla/application-services, or is that not necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sashei sashei merged commit 2fe6527 into master Apr 30, 2019
@sashei sashei deleted the 914-xcode-10.2 branch April 30, 2019 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Xcode 10.2
2 participants