Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Sorting options button #163

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Sorting options button #163

merged 2 commits into from
Mar 30, 2018

Conversation

sashei
Copy link
Contributor

@sashei sashei commented Mar 16, 2018

resolves #71

@sashei sashei force-pushed the 71-sorting-options branch from eb2e933 to 7275060 Compare March 19, 2018 23:59
@sashei sashei changed the title Sorting options button wip Sorting options button Mar 20, 2018
@sashei sashei force-pushed the 71-sorting-options branch 3 times, most recently from 99d9372 to 4bd6a9c Compare March 27, 2018 16:04
@sashei sashei requested a review from linuxwolf March 27, 2018 16:07
devinreams
devinreams reviewed Mar 28, 2018
View reviewed changes
Copy link
Contributor

@devinreams devinreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me on first load but has not since then.

  • tapped "A-Z" button to select "Recently Used"
  • saw the nice animation "swoop" the items into a new order ✅
  • tapped "A-Z" button to select "Alphabetically"
  • saw the nice animation put "Amazon" back on top ✅
  • tapped around and did more stuff (open entries, copy user/pass)
  • went back to change to "Recently Used" and everything sits in the same spot ⚠️

Is that expected and just a side-effect of the hard-coded "used" values in the datastore?

@sashei sashei force-pushed the 71-sorting-options branch from 4bd6a9c to bb01b65 Compare March 28, 2018 17:11
@sashei
Copy link
Contributor Author

sashei commented Mar 28, 2018

Nope, the updating should happen live. Investigating.

@sashei
Copy link
Contributor Author

sashei commented Mar 28, 2018

@devinreams check out the most recent build when it comes thru.

devinreams
devinreams reviewed Mar 28, 2018
View reviewed changes
Copy link
Contributor

@devinreams devinreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That works really well for me now. (Though I did have to completely delete the Branch app and re-install, I blame buddybuild).

Even when combined with filtering all the sort/re-sorting put items back where expected. 😍 ✅

linuxwolf
linuxwolf approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@linuxwolf linuxwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

:shipit:

@sashei sashei merged commit f1e5ae4 into master Mar 30, 2018
@sashei sashei deleted the 71-sorting-options branch March 30, 2018 17:00
@devinreams devinreams added this to the Sprint 1 milestone Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinreams devinreams devinreams left review comments

@linuxwolf linuxwolf linuxwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

Sorting options
3 participants
@sashei @devinreams @linuxwolf