This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
touch item #158
Merged
touch item #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashei
force-pushed
the
152-update-last-used
branch
2 times, most recently
from
b7d51d2 to
c850655
Compare
sashei
force-pushed
the
152-update-last-used
branch
from
c850655 to
407fcba
Compare
jhugman
approved these changes
Mar 16, 2018
|
|
||
| let jsonItem = try self.parser.jsonStringFromItem(item) | ||
|
|
||
| return self.webView.evaluateJavaScript("\(self.dataStoreName).touch(\(jsonItem))") |
There was a problem hiding this comment.
I… don't… understand… this code.
Doesn't evaluateJavascript return void? Oh, god it, Rx monkey patches.
| self = date | ||
| } else { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Nit: Could you document some of the sample strings this is expected to handle?
There was a problem hiding this comment.
Does the test count as documentation here? Or are you saying that I could include more cases in the spec file to be more thorough?
| .map { items in | ||
| guard let id = item.id else { | ||
| return items | ||
| } |
| @@ -68,4 +68,14 @@ class SwiftInteropDataStore extends DataStoreModule.DataStore { | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| async touch(item) { | |||
| return super.touch(item).then( function(updatedItem) { | |||
There was a problem hiding this comment.
Nit: Use
updatedItem => {}instead of function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #152