Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Add Telemetry to opening External Websites #1088

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Add Telemetry to opening External Websites #1088

merged 1 commit into from
Jul 11, 2019

Conversation

joeyg
Copy link
Contributor

@joeyg joeyg commented Jul 10, 2019

Fixes #1087.

@joeyg joeyg requested a review from a team as a code owner July 10, 2019 23:16
@joeyg joeyg self-assigned this Jul 10, 2019
eliserichards
eliserichards approved these changes Jul 10, 2019
View reviewed changes
Copy link

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

irrationalagent
irrationalagent approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@irrationalagent irrationalagent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 👍

@joeyg joeyg merged commit 4bd107a into master Jul 11, 2019
@joeyg joeyg deleted the external-website-telemetry branch July 11, 2019 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliserichards eliserichards eliserichards approved these changes

@irrationalagent irrationalagent irrationalagent approved these changes

Assignees

@joeyg joeyg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry action for settingsProvideFeedback no longer exists
3 participants
@joeyg @irrationalagent @eliserichards