This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
implement sync timeout #1045
Merged
implement sync timeout #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxwolf
approved these changes
Jun 5, 2019
| @@ -72,6 +72,7 @@ class Constant { | |||
| static let usernamePlaceholder = NSLocalizedString("username_placeholder", value: "(no username)", comment: "Placeholder text when there is no username. String should include appropriate open/close parenthetical or similar symbols to indicate this is a placeholder, not a real username.") | |||
| static let searchYourEntries = NSLocalizedString("search.placeholder", value: "Search logins", comment: "Placeholder text for search field") | |||
| static let emptyListPlaceholder = NSLocalizedString("list.empty", value: "%@ lets you access passwords you’ve already saved to Firefox. To view your logins here, you’ll need to sign in and sync with Firefox.", comment: "Label shown when there are no logins to list. %@ will be replaced with the application name") | |||
| static let syncTimedOut = NSLocalizedString("sync.timeout", value: "Sync timed out", comment: "This is the message displayed when syncing entries from the server times out") | |||
There was a problem hiding this comment.
Is there anyone we need to inform of new/changed localized strings?
Shared/Store/BaseDataStore.swift
Outdated
| return | ||
| } | ||
|
|
||
| queue.async { | ||
| self.queue.asyncAfter(deadline: .now() + 20, execute: { |
There was a problem hiding this comment.
this queues for 20 seconds from .now(), correct? I ask because I am not super-familiar with the interface, and most other systems seem to use milliseconds.
Also, is it worth making 20 a constant?
There was a problem hiding this comment.
yes, it queues for 20 seconds from now. Constant is a good idea!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1025
Testing and Review Notes
Not sure the best way to test this other than Network Link Conditioner / being on a very slow connect.
To Do