Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

1014 es l10n fixes #1026

Merged
merged 3 commits into from
May 29, 2019
Merged

1014 es l10n fixes #1026

merged 3 commits into from
May 29, 2019

Conversation

sashei
Copy link
Contributor

@sashei sashei commented May 29, 2019

Fixes #1014

Testing and Review Notes

The one issue that I couldn't fix was the incorrect gender for the copiado/a... We interpolate the string for username and password irrespective of gender, so I think making a larger change to introduce separate strings for Username Copied and Password Copied is out of scope for now.

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@sashei sashei requested a review from a team as a code owner May 29, 2019 16:55
@sashei
Copy link
Contributor Author

sashei commented May 29, 2019

@devinreams @Pike what is the process for uplifting reported string errors to Pontoon?

@devinreams
Copy link
Contributor

image

I just looked at the report from Isabel. Any others or just this one?

@sashei
Copy link
Contributor Author

sashei commented May 29, 2019

@devinreams well, see my comment above about doing the Username / Password copied substitution in gendered languages >.<

@sashei
Copy link
Contributor Author

sashei commented May 29, 2019

also @isabelrios I see a localized FxA login in French, just not in Spanish. Not sure what the story is there.

@devinreams
Copy link
Contributor

see my comment above about doing the Username / Password copied substitution

Ah yes, I agreed with you it would be out of scope and require redoing/breaking strings so I'll file this follow-up: #1028

see a localized FxA login in French, just not in Spanish. Not sure what the story is there.

I also see a German localized page. So this seems like an FxA language detection bug perhaps...

@Pike
Copy link
Contributor

Pike commented May 29, 2019

Leaving the suggestion in pontoon is the right way to do it, thanks.

Copy link
Contributor

@devinreams devinreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed fixes for:

  • 1-Recently Used is not correctly translated. ✅ (and submitted fix upstream)
  • 2- When entries are sorted by Recent, the name in the button is shown with ellipsis ✅
    image
  • 3- Username and Password copied message is not correct. ✅ (fixed constraints, follow up for gendered verb at Separate the strings for Username and Password copied #1028)
    image
  • 4- The screen to enter the password when logging in is not correct ✅ (seemed to be a locale issue but shows the right strings for me now)
    image

@sashei sashei merged commit a15afd0 into master May 29, 2019
@sashei sashei deleted the 1014-es-l10n-fixes branch May 29, 2019 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Spanish) Localization issues
4 participants