20190622 1117 #6
Conversation
| <note>Bundle display name</note> | ||
| </trans-unit> | ||
| <trans-unit id="CFBundleName"> | ||
| <source>Firefox Lockbox</source> |
There was a problem hiding this comment.
With this re-inclusion it's due to the way the CFBundleName works and its tied to a bunch of things throughout the Xcode project. I tried to surgically rename it in some places but it ended up breaking things in others, sadly. I'm not clever enough to get this a) removed from the strings nor b) get it renamed in the project without breaking other assumptions elsewhere.
| <trans-unit id="hwO-wS-oS4.text"> | ||
| <source>Take your passwords everywhere</source> | ||
| <target>Lleva tus contraseñas a todos lados</target> | ||
| <note>Class = "UILabel"; text = "Take your passwords everywhere"; ObjectID = "hwO-wS-oS4";</note> | ||
| </trans-unit> | ||
| </body> | ||
| </file> | ||
| <file original="lockbox-ios/Common/Resources/InfoPlist.strings" source-language="en" target-language="es" datatype="plaintext"> | ||
| <file original="lockbox-ios/Common/Resources/Strings/InfoPlist.strings" source-language="en" target-language="es" datatype="plaintext"> |
There was a problem hiding this comment.
This is due to the change found/discussed at #5
There was a problem hiding this comment.
@Delphine , this change is gonna drop the localizations that currently exist for this segment, notably, this is all the removed <target>Lockwise</target> lines like https://github.com/mozilla-l10n/lockwiseios-l10n/pull/6/files#diff-5a7f14dd031edb60ff7fffcf4890f0e2L111 in the attached files.
I think that's OK, as this particular string falls back to correct English brand name anyway, but I'd like you to confirm that call.
This supersedes #5 and includes a few new strings as part of the 1.6.x series of development and app improvements.
@Pike based on this diff to the
ios-l10n-scriptsexport script..... I think this resulting PR is looking much better with less "surprises" around file paths (just the adding to the "Strings" directory). How's it look to you all?