Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Remove references to Lockbox #3

Merged
merged 3 commits into from
May 17, 2019
Merged

Remove references to Lockbox #3

merged 3 commits into from
May 17, 2019

Conversation

flodolo
Copy link
Contributor

@flodolo flodolo commented May 17, 2019

Strings will need to be fixed upstream and re-exported.
Comments need to be fixed upstream, replacing the name.

@flodolo flodolo requested a review from Delphine as a code owner May 17, 2019 18:29
@flodolo flodolo requested a review from Pike May 17, 2019 18:30
@flodolo flodolo self-assigned this May 17, 2019
@flodolo
Copy link
Contributor Author

flodolo commented May 17, 2019

For reference, the process is to update the en-US file (normally, that would be exported from Xcode), then run

# Update other locales
~/ios-l10n-scripts/update-xliff.py . lockwise-ios.xliff

# Clean up templates
~/ios-l10n-scripts/clean-xliff.py templates lockwise-ios.xliff

@Pike Pike merged commit b8c623c into master May 17, 2019
@flodolo flodolo deleted the cleanup_lockbox branch May 17, 2019 18:41
@devinreams devinreams mentioned this pull request May 22, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Pike Pike Pike approved these changes

@Delphine Delphine Awaiting requested review from Delphine Delphine is a code owner

Assignees

@flodolo flodolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flodolo @Pike