Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXVPN-341: Add 'next' button to first run telemetry screen #189

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

lesleyjanenorton
Copy link
Member

This PR adds a 'next' button to the first run telemetry screen that opens the browserAction popup onClick.

Screen.Recording.2025-01-14.at.1.34.42.PM.mov

Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/ Should we close the page tho?

@lesleyjanenorton
Copy link
Member Author

lesleyjanenorton commented Jan 14, 2025

Can/ Should we close the page tho?

@basti Good question. I just pinged Santiago. I'm going to merge this as is so that QA can take this for a run tomorrow and if we want to also close the tab onClick we can update the behavior in a follow up.

@lesleyjanenorton lesleyjanenorton merged commit 3bf229d into main Jan 14, 2025
5 checks passed
@lesleyjanenorton lesleyjanenorton deleted the fxvpn-341 branch January 14, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants