Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: user-defined field aliases may break federation #94

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Fix: user-defined field aliases may break federation #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/algorithms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,8 @@ function ExtractSelectionSet(ctx, insertionPoint, parentType, selectionSet, loca
append childrenSteps to the result's query plan steps
}
}
if parentType is a boundary type and the result selectionSet doesn't have an "id" field {
add the "id" field to the result selectionSet, aliased to "_id"
if parentType is a boundary type {
add the "id" field to the result selectionSet, aliased as "_bramble_id"
}
return result :: (ast.SelectionSet, []QueryPlanStep)
}
Expand Down
Loading