Fix: merge composite scopes in final selection #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with the final filtering of non-distinct composite field selections, per #87.
The Problem
Multiple selection scopes applied to the same object selection were not getting combined in the final result, for example:
While this query properly fetched all requested data from underlying services (i.e.: query planning worked as expected), the resulting data only included fields for the first distinct
products
selection scope:The Fix
This adjusts
unionAndTrimSelectionSetRec
, where the mapping of "seenFields" was filtering all repeated selection names as though they were leaf values. This new implementation has repeat composite fields merge their selections together.Resolves #87.