This repository has been archived by the owner on May 4, 2024. It is now read-only.
[verifier] add version-gating to type instantiation check #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78a9e2b was known to be a breaking change, but it was unclear whether it would break real code. Turns out that it does, so preserve the old behavior in older bytecode versions
sblackshear
force-pushed
the
add_version_gating
branch
from
427d4a8 to
871df22
Compare
wrwg
approved these changes
Dec 20, 2022
wrwg
added a commit
that referenced
this pull request
Dec 25, 2022
* [verifier] check type instantiations behind a reference or inside vector generics (#758) The verifier current doesn't check ability constraints on types that are behind a reference, or inside a vector (i.e., the `T` in `&T`, `&mut T`, or `vector<T>`). This sounds alarming, but is fortunately not possible to take advantage of because doing so always creates a bad struct instantiation that will be flagged b the ability checker. Fix the bug in version 7--left it in version 6 and below because it is (to the best of our understanding) harmless and the fix is a breaking change in the verifier--it will reject some function declarations that were previously accepted. * [tools] print imports, fully qualified function names in disassembler (#757) Previously, the disassembler did not print dependency information or use fully qualified function names. That makes it difficult to see what code a module is using/which functions it's calling, and (in the case of name conflicts) can create ambiguity. - Add a module alias map to the disassembler state that disambiguates between modules with the same name - Use the alias map to print dep info, using source langauge syntax. Resolve name conflicts using `as` (again, like the source langguage). - Also print fully qualified function names. Internal function calls have no module name prefix or `::`, as in the source language. See added test for details on what the printed output looks like + how conflicts are resolved. * [misc] add Move logo images (#709) * [verifier] add version-gating to type instantiation check (#762) 78a9e2b was known to be a breaking change, but it was unclear whether it would break real code. Turns out that it does, so preserve the old behavior in older bytecode versions * [compiler] Fix instantiation of field types with type parameters (#764) - Fixed a bug where ability constraints where not properly checked for fields containing the structs type parameter Co-authored-by: Sam Blackshear <[email protected]> Co-authored-by: Todd Nowacki <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
78a9e2b was known to be a breaking change, but it was unclear whether it would break real code. Turns out that it does, so preserve the old behavior in older bytecode versions.